Optimised Delete Flight Path Function and changed flight Analyser button from private to public

src/main/java/seng202/group9/Controller/Dataset.java

@@ -1545,7 +1545,12 @@ public class Dataset {
     public void deleteFlightPath(FlightPath flightPath){
         //delete all flight points with the id
         while(flightPath.getFlightPoints().size() > 0){
-            deleteFlightPoint(flightPath.getFlightPoints().get(0), flightPath);
+            try {
+                flightPointDictionary.remove(flightPath.getFlightPoints().get(0).getID());
+                flightPath.getFlightPoints().remove(0);
+            } catch (DataException e) {
+                e.printStackTrace();
+            }
         }
         //drop the entries
         Connection c = null;
@@ -1605,6 +1610,7 @@ public class Dataset {
             stmt.close();
 
             int index = flightPath.getFlightPoints().indexOf(flightPoint);
+            System.out.println(index);
 
             if (index == 0){
                 try {

src/main/java/seng202/group9/GUI/FlightRDController.java

@@ -261,7 +261,7 @@ public class FlightRDController extends Controller {
     /**
      * Will link to the flight analyser when implemented.
      */
-    private void flightAnalyser(){
+    public void flightAnalyser(){
         JOptionPane.showMessageDialog(null, "This is not Implemented yet");
     }